abbccdda commented on a change in pull request #8997:
URL: https://github.com/apache/kafka/pull/8997#discussion_r453144756
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -1113,6 +1135,7 @@ private boolean addClientAssignments(final Map<String,
Assignment> assignment,
final
ClientState clientState) {
final Map<TaskId, Set<TopicPartition>> standbyTaskMap = new
HashMap<>();
for (final TaskId task : standbys) {
+ clientState.assignStandbyToConsumer(task, consumer);
Review comment:
Similar here, if we have logical change, probably we need to add more
tests.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -1078,6 +1098,8 @@ private boolean addClientAssignments(final Map<String,
Assignment> assignment,
);
removedActiveTasks.add(taskId);
+ clientState.revokeActiveFromConsumer(taskId, consumer);
Review comment:
Is this a logic change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
