cmccabe commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r453879092
##########
File path: clients/src/main/resources/common/message/RequestHeader.json
##########
@@ -37,6 +37,9 @@
// Since the client is sending the ApiVersionsRequest in order to discover
what
// versions are supported, the client does not know the best version to
use.
{ "name": "ClientId", "type": "string", "versions": "1+",
"nullableVersions": "1+", "ignorable": true,
- "flexibleVersions": "none", "about": "The client ID string." }
+ "flexibleVersions": "none", "about": "The client ID string." },
+ // Could not set default to null, because not all versions of this field
are nullable.
Review comment:
Why not just make all versions of the field nullable by setting a
`nullVersions: "2+"`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
