jeffkbkim commented on a change in pull request #8935:
URL: https://github.com/apache/kafka/pull/8935#discussion_r454039899



##########
File path: core/src/main/scala/kafka/controller/ControllerEventManager.scala
##########
@@ -139,4 +140,19 @@ class ControllerEventManager(controllerId: Int,
     }
   }
 
+  private def pollFromEventQueue(): QueuedEvent = {

Review comment:
       @junrao Two of the biggest issues is that the histogram does not reset 
when the broker shuts down or when the controller moves. There will not be a 
next `get()/update()` in these scenarios - should we reset the histogram 
outside of `ControllerEventThread` instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to