dima5rr commented on a change in pull request #9020:
URL: https://github.com/apache/kafka/pull/9020#discussion_r455939491
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/WrappingStoreProvider.java
##########
@@ -46,11 +46,22 @@ public void setStoreQueryParameters(final
StoreQueryParameters storeQueryParamet
public <T> List<T> stores(final String storeName,
final QueryableStoreType<T> queryableStoreType) {
final List<T> allStores = new ArrayList<>();
- for (final StreamThreadStateStoreProvider provider : storeProviders) {
- final List<T> stores = provider.stores(storeQueryParameters);
- allStores.addAll(stores);
+ for (final StreamThreadStateStoreProvider storeProvider :
storeProviders) {
+ final List<T> stores = storeProvider.stores(storeQueryParameters);
+ if (!stores.isEmpty()) {
+ allStores.addAll(stores);
+ if (storeQueryParameters.partition() != null) {
+ break;
+ }
+ }
}
if (allStores.isEmpty()) {
+ if (storeQueryParameters.partition() != null) {
+ throw new InvalidStateStoreException(
+ String.format("The specified partition %d for store %s
does not exist.",
Review comment:
L65 catches on rebalancing, while L60 is parameter validation for
incorrect partition case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
