ijuma commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r456196331
##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/Readable.java
##########
@@ -35,6 +36,10 @@
int readUnsignedVarint();
ByteBuffer readByteBuffer(int length);
+ default BaseRecords readRecords(int length) {
+ throw new UnsupportedOperationException("Not implemented");
+ }
Review comment:
Is this and the respective `writeRecords` in the base interface needed?
It seems like they're only implemented in two specific cases. Could we not
downcast for those cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
