[GitHub] [kafka] rajinisivaram commented on a change in pull request #8933: KAFKA-10163; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part I, Broker Changes)

[GitBox]

rajinisivaram commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r456371880



##########
File path: core/src/main/scala/kafka/server/ClientQuotaManager.scala
##########
@@ -154,32 +180,40 @@ object ClientQuotaManager {
  * @param config @ClientQuotaManagerConfig quota configs
  * @param metrics @Metrics Metrics instance
  * @param quotaType Quota type of this quota manager
+ * @param quotaEnforcementType Quota enforcement type of this quota manager. 
Refers to the
+ *                             documentation of {recordAndGetThrottleTimeMs} 
for details
  * @param time @Time object to use
+ * @param threadNamePrefix The thread prefix to use
+ * @param clientQuotaCallback An optional @ClientQuotaCallback
  */
 class ClientQuotaManager(private val config: ClientQuotaManagerConfig,
                          private val metrics: Metrics,
                          private val quotaType: QuotaType,
+                         private val quotaEnforcementType: 
QuotaEnforcementType,

Review comment:
       It looks like we don't need this change since the only one that sets a 
different type does its own thing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org