serjchebotarev commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r456791046
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##########
@@ -265,7 +265,7 @@ public void
shouldNotAllowToResetWhenIntermediateTopicAbsent() throws Exception
public void testResetWhenLongSessionTimeoutConfiguredWithForceOption()
throws Exception {
Review comment:
Done. Moved tests to derived class.
Also in the last commit (8218891):
- Refactored how `testId` gets set. Instead of class-level variable it is
set via `getTestId()` method which was declared as abstract in
`AbstractResetIntegrationTest` (now it cannot be forgotten to be set in derived
classes).
- Removed `appID` instance variable (removed instance-level state).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
