dajac commented on a change in pull request #8768:
URL: https://github.com/apache/kafka/pull/8768#discussion_r457390034
##########
File path:
clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java
##########
@@ -97,5 +99,13 @@ public MetricConfig recordLevel(Sensor.RecordingLevel
recordingLevel) {
return this;
}
+ public boolean skipReporting() {
Review comment:
I asked the very same question:
https://github.com/apache/kafka/pull/8768#discussion_r433705077. Basically, we
already have the same metrics defined as part of the `SelectorMetrics` so the
ones added here collides.
Thinking a bit more about this, I wonder if we could use Sensors without
adding them to the registry at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
