[GitHub] [kafka] mjsax commented on a change in pull request #8864: KAFKA-9274: Mark `retries` config as deprecated and add new `task.timeout.ms` config

[GitBox]

mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r457707335



##########
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##########
@@ -146,7 +148,7 @@ object ConsoleProducer {
       .describedAs("size")
       .ofType(classOf[java.lang.Integer])
       .defaultsTo(200)
-    val messageSendMaxRetriesOpt = parser.accepts("message-send-max-retries", 
"Brokers can fail receiving the message for multiple reasons, and being 
unavailable transiently is just one of them. This property specifies the number 
of retires before the producer give up and drop this message.")
+    val messageSendMaxRetriesOpt = parser.accepts("message-send-max-retries", 
"(Deprecated) Brokers can fail receiving the message for multiple reasons, and 
being unavailable transiently is just one of them. This property specifies the 
number of retires before the producer give up and drop this message.")

Review comment:
       Updated the KIP and sent a mail to the VOTE thread on the dev list.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org