mjsax commented on a change in pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#discussion_r457751610
##########
File path:
streams/src/main/java/org/apache/kafka/streams/errors/InvalidStateStoreException.java
##########
@@ -18,13 +18,8 @@
/**
- * Indicates that there was a problem when trying to access a
- * {@link org.apache.kafka.streams.processor.StateStore StateStore}, i.e, the
Store is no longer valid because it is
- * closed or doesn't exist any more due to a rebalance.
- * <p>
- * These exceptions may be transient, i.e., during a rebalance it won't be
possible to query the stores as they are
- * being (re)-initialized. Once the rebalance has completed the stores will be
available again. Hence, it is valid
- * to backoff and retry when handling this exception.
+ * <p>Indicates that there was a problem when trying to access a {@link
org.apache.kafka.streams.processor.StateStore StateStore}.
Review comment:
Nit: we don't need the `<p>` tag because there is only one paragraph.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/errors/InvalidStateStoreException.java
##########
@@ -18,13 +18,8 @@
/**
- * Indicates that there was a problem when trying to access a
- * {@link org.apache.kafka.streams.processor.StateStore StateStore}, i.e, the
Store is no longer valid because it is
- * closed or doesn't exist any more due to a rebalance.
- * <p>
- * These exceptions may be transient, i.e., during a rebalance it won't be
possible to query the stores as they are
- * being (re)-initialized. Once the rebalance has completed the stores will be
available again. Hence, it is valid
- * to backoff and retry when handling this exception.
+ * <p>Indicates that there was a problem when trying to access a {@link
org.apache.kafka.streams.processor.StateStore StateStore}.
+ * {@code InvalidStateStoreException} not thrown directly but only following
sub-classes.
Review comment:
Nit: `Note that {@code InvalidStateStoreException} [is] not thrown
directly but only [its] sub-classes.`
##########
File path:
streams/src/main/java/org/apache/kafka/streams/errors/StreamsNotStartedException.java
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.streams.errors;
+
+import org.apache.kafka.streams.KafkaStreams;
+
+/**
+ * Indicates that Kafka Streams is in state {@link KafkaStreams.State#CREATED
CREATED} and thus state stores cannot be queries yet.
+ * To query state stores, it's required to first start Kafka Streams via
{@link KafkaStreams#start()}.
+ * You can retry to query the state after the state transitioned to to {@link
KafkaStreams.State#RUNNING RUNNING}
Review comment:
typo `to to`
(also missing `.` at the end of the sentence)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
