rajinisivaram commented on a change in pull request #8768:
URL: https://github.com/apache/kafka/pull/8768#discussion_r457944837
##########
File path:
clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java
##########
@@ -97,5 +99,13 @@ public MetricConfig recordLevel(Sensor.RecordingLevel
recordingLevel) {
return this;
}
+ public boolean skipReporting() {
Review comment:
If we are using a sensor to determine throttle time that is different
from the one in Selector, we might want to expose it as a metric anyway. In
case of a bug, we want to know this metric, not one in Selector. Perhaps we
could use `connections-accepted` instead of `connections-created` or something
like that. In any case, `skipReporting` seems odd, so as @dajac said, using a
Sensor that is not added to the metrics registry may be an option too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
