[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163012#comment-17163012
]
John Roesler commented on KAFKA-8037:
-------------------------------------
Thanks for the reply [~guozhang] . I think we're on the same page.
It's a minor point, but to be clear about the suggestion to deprecate
`org.apache.kafka.streams.StreamsBuilder#build(java.util.Properties)`. It is
currently true that this is _only_ used to apply the source changelog
optimization. If we migrate to having a separate configuration per source, then
we don't need this method anymore. Deprecating it is a nice way to nudge people
to change their code to specify the config per source. Otherwise, if we just
want to stop using the optimization parameter for this optimization
(eventually), then the only way to "deprecate" it is to log a warning.
> KTable restore may load bad data
> --------------------------------
>
> Key: KAFKA-8037
> URL: https://issues.apache.org/jira/browse/KAFKA-8037
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Priority: Minor
> Labels: pull-request-available
>
> If an input topic contains bad data, users can specify a
> `deserialization.exception.handler` to drop corrupted records on read.
> However, this mechanism may be by-passed on restore. Assume a
> `builder.table()` call reads and drops a corrupted record. If the table state
> is lost and restored from the changelog topic, the corrupted record may be
> copied into the store, because on restore plain bytes are copied.
> If the KTable is used in a join, an internal `store.get()` call to lookup the
> record would fail with a deserialization exception if the value part cannot
> be deserialized.
> GlobalKTables are affected, too (cf. KAFKA-7663 that may allow a fix for
> GlobalKTable case). It's unclear to me atm, how this issue could be addressed
> for KTables though.
> Note, that user state stores are not affected, because they always have a
> dedicated changelog topic (and don't reuse an input topic) and thus the
> corrupted record would not be written into the changelog.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
