mumrah commented on pull request #9008: URL: https://github.com/apache/kafka/pull/9008#issuecomment-662794475
Thanks @cmccabe, great feedback. I've updated RecordsWriter to allocate a single ByteBuffer based on a pre-calculated length (total message size - all records size). This avoids the buffer resizing altogether. I like your suggestions for Writable#close and moving readRecords into ByteBufferAccessor. I'll save these for a follow-on ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org