showuon commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-664133647
hi @ning2008wisc , thanks for your suggestion. but I don't think it's good to merge all the 4 commits into 1. I think the commit history is a kind of records to keep why the author did this change at that time. Someone can always know why we did this change by checking the commit history or the PR records. Also, the reviewer can know which commits have reviewed, and which one is new added to address reviewer's previous comments (like the above comments I left to @mimaison ). I know there's some debate over that, but I think if this project(Kafka) doesn't have this rule, it should be fine to keep it as is. Thank you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
