[
https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166613#comment-17166613
]
John Thomas edited comment on KAFKA-10316 at 7/28/20, 6:17 PM:
---------------------------------------------------------------
[~mjsax] Yeah! I got the access to create KIP and have created KIP :
[KIP-648|https://cwiki.apache.org/confluence/display/KAFKA/KIP-648%3A+Renaming+getter+method+for+Interactive+Queries]
Its my first KIP documentation :) I followed the guidelines and I hope I'm
conveying the right thing. Could you do a quick check ?
A couple of questions :
* In the KIP process, the next steps are to start a discussion thread and
vote. Would this KIP need discussion ?
* Since its under Kafka Streams, I've made an entry under [Kafka+Streams
|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Streams] Do we need to
make an entry under
[Kafka+Improvement+Proposals|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals]
also.
was (Author: johnthotekat):
[~mjsax] I got the access to create KIP and have created KIP :
[KIP-648|https://cwiki.apache.org/confluence/display/KAFKA/KIP-648%3A+Renaming+getter+method+for+Interactive+Queries]
Its my first KIP documentation :) I followed the guidelines and I hope I'm
conveying the right thing. Could you do a quick check ?
A couple of questions :
* In the KIP process, the next steps are to start a discussion thread and
vote. Would this KIP need discussion ?
* Since its under Kafka Streams, I've made an entry under [Kafka+Streams
|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Streams] Do we need to
make an entry under
[Kafka+Improvement+Proposals|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals]
also.
> Consider renaming getter method for Interactive Queries
> -------------------------------------------------------
>
> Key: KAFKA-10316
> URL: https://issues.apache.org/jira/browse/KAFKA-10316
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Assignee: John Thomas
> Priority: Minor
> Labels: beginner, need-kip, newbie
>
> In the 2.5 release, we introduce new classes for Interactive Queries via
> KIP-535 (cf https://issues.apache.org/jira/browse/KAFKA-6144). The KIP did
> not specify the names for getter methods of `KeyQueryMetadata` explicitly and
> they were added in the PR as `getActiveHost()`, `getStandbyHosts()`, and
> `getPartition()`.
> However, in Kafka it is custom to not use the `get` prefix for getters and
> thus the methods should have been added as `activeHost()`, `standbyHosts()`,
> and `partition()`, respectively.
> We should consider renaming the methods accordingly, by deprecating the
> existing ones and adding the new ones in parallel.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
