lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r465334577
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java
##########
@@ -275,6 +275,15 @@
*/
<W extends Window> TimeWindowedCogroupedKStream<K, VOut> windowedBy(final
Windows<W> windows);
+ /**
+ * Create a new {@link TimeWindowedCogroupedKStream} instance that can be
used to perform sliding
+ * windowed aggregations.
+ *
+ * @param windows the specification of the aggregation {@link
SlidingWindows}
+ * @return an instance of {@link TimeWindowedCogroupedKStream}
+ */
+ TimeWindowedCogroupedKStream<K, VOut> windowedBy(final SlidingWindows
windows);
Review comment:
We could, but it would only pull out 3ish classes and not very many
lines, so I don't think it would make this PR feel much smaller
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
