cmccabe commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r465712943
##########
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##########
@@ -113,8 +113,8 @@ class BrokerToControllerChannelManager(metadataCache:
kafka.server.MetadataCache
brokerToControllerListenerName, time, threadName)
}
- private[server] def sendRequest(request: AbstractRequest.Builder[_ <:
AbstractRequest],
- callback: RequestCompletionHandler): Unit = {
+ def sendRequest(request: AbstractRequest.Builder[_ <: AbstractRequest],
+ callback: RequestCompletionHandler): Unit = {
requestQueue.put(BrokerToControllerQueueItem(request, callback))
Review comment:
This also needs to call `NetworkClient#wake` in case we are blocking
inside `NetworkClient#poll`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
