guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466085153
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -344,40 +343,41 @@ public void resume() {
}
/**
+ * @throws StreamsException fatal error that should cause the thread to die
+ * @throws TaskMigratedException recoverable error that would cause the
task to be removed
Review comment:
I think it is a good habit keeping that since those functions are called
by various callers and if the caller do not catch them, the the ancestor
callers should -- I've personally found such debugging very helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
