[GitHub] [kafka] guozhangwang commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

[GitBox]

guozhangwang commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r468983667



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -154,15 +153,15 @@ public StreamTask(final TaskId id,
         for (final String terminalNodeName : topology.terminalNodes()) {
             e2eLatencySensors.put(
                 terminalNodeName,
-                TaskMetrics.e2ELatencySensor(threadId, taskId, 
terminalNodeName, RecordingLevel.INFO, streamsMetrics)
+                TaskMetrics.e2ELatencySensor(threadId, taskId, 
terminalNodeName, streamsMetrics)

Review comment:
       NVM, I realized it is at the per-node metrics level, we just have two 
types of nodes (source and termination node) for each task.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org