rhauch commented on a change in pull request #9172:
URL: https://github.com/apache/kafka/pull/9172#discussion_r469586764



##########
File path: 
connect/runtime/src/test/java/org/apache/kafka/connect/integration/TransformationIntegrationTest.java
##########
@@ -318,4 +323,61 @@ public void testFilterOnHasHeaderKeyWithSourceConnector() 
throws Exception {
         // delete connector
         connect.deleteConnector(CONNECTOR_NAME);
     }
+
+    /**
+     * Test the {@link Filter} transformer with a
+     * {@link HasHeaderKey} predicate on a source connector.
+     */
+    @Test
+    public void testFilterOnHasHeaderKeyWithSourceConnectorAndTopicCreation() 
throws Exception {

Review comment:
       Sounds good. I just want to avoid someone trying to simplify the tests 
in the future without understanding that this test is verifying both features 
work together.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to