nizhikov commented on a change in pull request #9196:
URL: https://github.com/apache/kafka/pull/9196#discussion_r475188599
##########
File path: tests/kafkatest/services/verifiable_consumer.py
##########
@@ -372,7 +372,7 @@ def current_position(self, tp):
def owner(self, tp):
with self.lock:
- for handler in self.event_handlers.itervalues():
+ for handler in iter(self.event_handlers.values()):
Review comment:
fixed.
##########
File path: tests/kafkatest/services/verifiable_consumer.py
##########
@@ -361,7 +361,7 @@ def clean_node(self, node):
def current_assignment(self):
with self.lock:
- return { handler.node: handler.current_assignment() for handler in
self.event_handlers.itervalues() }
+ return { handler.node: handler.current_assignment() for handler in
iter(self.event_handlers.values()) }
Review comment:
fixed.
##########
File path: tests/kafkatest/services/security/security_config.py
##########
@@ -362,7 +362,7 @@ def props(self, prefix=''):
return ""
if self.has_sasl and not self.static_jaas_conf and 'sasl.jaas.config'
not in self.properties:
raise Exception("JAAS configuration property has not yet been
initialized")
- config_lines = (prefix + key + "=" + value for key, value in
self.properties.iteritems())
+ config_lines = (prefix + key + "=" + value for key, value in
iter(self.properties.items()))
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
