showuon commented on a change in pull request #9121:
URL: https://github.com/apache/kafka/pull/9121#discussion_r475358692



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/state/internals/OffsetCheckpointTest.java
##########
@@ -135,6 +136,20 @@ public void shouldThrowOnInvalidOffsetInWrite() throws 
IOException {
         }
     }
 
+    @Test
+    public void shouldThrowIOExceptionWhenWritingToNotExistedFile() {
+        final Map<TopicPartition, Long> offsetsToWrite = 
Collections.singletonMap(
+            new TopicPartition(topic, 0), 0L);
+
+        // create a file with not existed path, and feed into OffsetCheckpoint

Review comment:
       agree!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to