cmccabe commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r475725389
##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -316,7 +316,10 @@ class KafkaServer(val config: KafkaConfig, time: Time =
Time.SYSTEM, threadNameP
kafkaController = new KafkaController(config, zkClient, time, metrics,
brokerInfo, brokerEpoch, tokenManager, threadNamePrefix)
kafkaController.startup()
- brokerToControllerChannelManager = new
BrokerToControllerChannelManager(metadataCache, time, metrics, config,
threadNamePrefix)
+ if (config.redirectionEnabled) {
+ brokerToControllerChannelManager = new
BrokerToControllerChannelManager(metadataCache, time, metrics, config,
threadNamePrefix)
Review comment:
just as a note the alter isr PR may also have an object like this. so
maybe we want a name which is more specific to redirection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
