ableegoldman commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r475999351
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryWindowStore.java
##########
@@ -419,13 +504,13 @@ Long minTime() {
}
Review comment:
I agree that it doesn't matter much, but I think it has to be "reverse"
for both time and keys for correctness due to CachingWindowStore. The caching
layer just puts everything into one byte buffer so when we go in reverse order
it's just the opposite of forward, which means both key and time ordering is
flipped. And we unfortunately need the ordering to match up between the cache
and the underlying store due to that merging iterator guy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
