[ 
https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184778#comment-17184778
 ] 

Sophie Blee-Goldman commented on KAFKA-10434:
---------------------------------------------

Gotcha. Then can we at least put this explanation in the comments, the current 
{code:java}
// note, this method must be kept if super#fetch(...) is removed
{code}
comments are not particularly illuminating. 

[~jeqo] I guess we would indeed want to use the `long` version of the signature 
for the underlying store in the reverse iterator PR (and add them to the 
WindowStore API). 

Thanks for clarifying [~mjsax]

 

> Remove deprecated methods on WindowStore
> ----------------------------------------
>
>                 Key: KAFKA-10434
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10434
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Jorge Esteban Quilcate Otoya
>            Priority: Major
>
> From [https://github.com/apache/kafka/pull/9138#discussion_r474985997] and 
> [https://github.com/apache/kafka/pull/9138#discussion_r474995606] :
> WindowStore contains ReadOnlyWindowStore methods.
> We could consider:
>  * Moving read methods from WindowStore to ReadOnlyWindowStore and/or
>  * Consider removing long based methods



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to