lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478462394
########## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ########## @@ -232,40 +239,54 @@ private void processEarly(final K key, final V value, final long timestamp, fina final long startTime = next.key.window().start(); final long endTime = startTime + windows.timeDifferenceMs(); - if (endTime == windows.timeDifferenceMs()) { + if (startTime == 0) { combinedWindow = next; - } else if (endTime > timestamp && startTime <= timestamp) { + } else if (endTime >= timestamp && startTime <= timestamp) { Review comment: Yeah I think you're right, I'll take it out ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org