ijuma commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479474904
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -100,7 +102,8 @@ case class LogAppendInfo(var firstOffset: Option[Long],
offsetsMonotonic: Boolean,
lastOffsetOfFirstBatch: Long,
recordErrors: Seq[RecordError] = List(),
- errorMessage: String = null) {
+ errorMessage: String = null,
+ leaderHWIncremented: Option[Boolean] = None) {
Review comment:
Can we not use a `boolean` here? `false` until it's been incremented and
then `true`. Is there value in having the third state?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
