chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r479677889
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -180,6 +181,11 @@ class KafkaApis(val requestChannel: RequestChannel,
case ApiKeys.DESCRIBE_CLIENT_QUOTAS =>
handleDescribeClientQuotasRequest(request)
case ApiKeys.ALTER_CLIENT_QUOTAS =>
handleAlterClientQuotasRequest(request)
}
+
+ // try to complete delayed action. In order to avoid conflicting
locking, the actions to complete delayed requests
+ // are kept in a queue. We add the logic to check the ReplicaManager
queue at the end of KafkaApis.handle() and the
+ // expiration thread for certain delayed operations (e.g. DelayedJoin)
+ actionQueue.tryCompleteAction()
Review comment:
Completing delayed actions may cause exception. Should exception be
swallowed and log if we move the completion to the final block?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
