asdaraujo commented on a change in pull request #8730:
URL: https://github.com/apache/kafka/pull/8730#discussion_r480267347
##########
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##########
@@ -190,24 +211,19 @@ public void close() {
public void testReplication() throws InterruptedException {
// create consumers before starting the connectors so we don't need to
wait for discovery
- Consumer<byte[], byte[]> consumer1 =
primary.kafka().createConsumerAndSubscribeTo(Collections.singletonMap(
- "group.id", "consumer-group-1"), "test-topic-1",
"backup.test-topic-1");
+ Consumer<byte[], byte[]> consumer1 =
primary.kafka().createConsumerAndSubscribeTo(consumerProps, "test-topic-1",
"backup.test-topic-1");
consumer1.poll(Duration.ofMillis(500));
consumer1.commitSync();
consumer1.close();
- Consumer<byte[], byte[]> consumer2 =
backup.kafka().createConsumerAndSubscribeTo(Collections.singletonMap(
- "group.id", "consumer-group-1"), "test-topic-1",
"primary.test-topic-1");
+ Consumer<byte[], byte[]> consumer2 =
backup.kafka().createConsumerAndSubscribeTo(consumerProps, "test-topic-1",
"primary.test-topic-1");
Review comment:
Good catch. Also changed this and we're now consuming it only once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
