rhauch commented on a change in pull request #8918:
URL: https://github.com/apache/kafka/pull/8918#discussion_r481251133
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -475,7 +475,7 @@ private synchronized void recordSent(final
ProducerRecord<byte[], byte[]> record
public boolean commitOffsets() {
long commitTimeoutMs =
workerConfig.getLong(WorkerConfig.OFFSET_COMMIT_TIMEOUT_MS_CONFIG);
- log.info("{} Committing offsets", this);
+ log.trace("{} Committing offsets", this);
Review comment:
Why set this to `trace` rather than `debug` like the other changes?
Isn't it useful to know that we've entered this method before we lock?
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -571,7 +571,7 @@ public boolean commitOffsets() {
finishSuccessfulFlush();
long durationMillis = time.milliseconds() - started;
recordCommitSuccess(durationMillis);
- log.info("{} Finished commitOffsets successfully in {} ms",
+ log.trace("{} Finished commitOffsets successfully in {} ms",
Review comment:
Same question here about `trace` vs `debug`, as denoted above. With
debug logs, isn't it useful to know how long it took to commit all offsets?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
