ableegoldman commented on a change in pull request #9157:
URL: https://github.com/apache/kafka/pull/9157#discussion_r481512388
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##########
@@ -118,24 +118,20 @@ public void process(final K key, final V value) {
}
final long timestamp = context().timestamp();
- //don't process records that don't fall within a full sliding
window
+ final long closeTime = observedStreamTime -
windows.gracePeriodMs();
+
Review comment:
By the way, I think we should also check if the record is so old that
even the latest window it could possibly create/affect would be dropped, and
then not process the record at all. (ie basically check if the current record's
right window would be dropped) We can record on the lateRecordDropSensor and
log the message using the current record's left window.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
