lct45 commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r483152129



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -608,10 +615,13 @@ public void testAggregateRandomInput() {
 
     private void verifyRandomTestResults(final Map<Long, 
ValueAndTimestamp<String>> actual) {

Review comment:
       Yeah I think running on both is definitely good to have. Along that 
line, should benchmark run with both reverse and forward? It could indicate if 
reverse is actually more efficient or if they run about the same




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to