ableegoldman commented on a change in pull request #9157:
URL: https://github.com/apache/kafka/pull/9157#discussion_r483828060
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##########
@@ -228,13 +345,8 @@ private void putAndForward(final Window window,
if (windowEnd > closeTime) {
//get aggregate from existing window
final Agg oldAgg = getValueOrNull(valueAndTime);
- final Agg newAgg;
- // keep old aggregate if adding a right window, else add new
record's value
- if (windowStart == timestamp + 1) {
- newAgg = oldAgg;
- } else {
- newAgg = aggregator.apply(key, value, oldAgg);
- }
+ final Agg newAgg = aggregator.apply(key, value, oldAgg);
Review comment:
This was just from the semi-related cleanup of splitting `putAndForward`
into a separate method for `createRightWindow`, which was done after the first
PR was merged (hence the cleanup occurs in this PR). I think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
