ning2008wisc commented on a change in pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#discussion_r485362458



##########
File path: 
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTest.java
##########
@@ -207,13 +173,16 @@ public void testReplication() throws InterruptedException 
{
 
         mm2Config = new MirrorMakerConfig(mm2Props);
 
-        waitUntilMirrorMakerIsRunning(backup, mm2Config, "primary", "backup");
+        waitUntilMirrorMakerIsRunning(backup, CONNECTOR_LIST, mm2Config, 
"primary", "backup");
 
-        waitUntilMirrorMakerIsRunning(primary, mm2Config, "backup", "primary");
+        waitUntilMirrorMakerIsRunning(primary, CONNECTOR_LIST, mm2Config, 
"backup", "primary");   
 
         MirrorClient primaryClient = new 
MirrorClient(mm2Config.clientConfig("primary"));
         MirrorClient backupClient = new 
MirrorClient(mm2Config.clientConfig("backup"));
-
+        
+        assertEquals("topic config was not synced", 
TopicConfig.CLEANUP_POLICY_COMPACT, 
+                getTopicConfig(backup.kafka(), "primary.test-topic-1", 
TopicConfig.CLEANUP_POLICY_CONFIG));

Review comment:
       Add a check for topic config sync, since the topic created on primary 
cluster has a "cleanup.policy" config




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to