chia7712 commented on a change in pull request #9278:
URL: https://github.com/apache/kafka/pull/9278#discussion_r486027311
##########
File path: core/src/test/scala/unit/kafka/cluster/PartitionTest.scala
##########
@@ -922,102 +918,6 @@ class PartitionTest extends AbstractPartitionTest {
assertEquals("ISR", Set[Integer](leader, follower1, follower2),
partition.inSyncReplicaIds)
}
- /**
- * Verify that delayed fetch operations which are completed when records are
appended don't result in deadlocks.
- * Delayed fetch operations acquire Partition leaderIsrUpdate read lock for
one or more partitions. So they
- * need to be completed after releasing the lock acquired to append records.
Otherwise, waiting writers
- * (e.g. to check if ISR needs to be shrinked) can trigger deadlock in
request handler threads waiting for
- * read lock of one Partition while holding on to read lock of another
Partition.
- */
- @Test
- def testDelayedFetchAfterAppendRecords(): Unit = {
Review comment:
```appendRecordsToLeader`` does not complete delayed fetch anymore
(c2273adc25b2bab0a3ac95bf7844fedf2860b40b) so this test can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
