mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r486521810
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -255,6 +265,15 @@ class Partition(val topicPartition: TopicPartition,
def isAddingReplica(replicaId: Int): Boolean =
assignmentState.isAddingReplica(replicaId)
+ def inSyncReplicaIds(includeUncommittedReplicas: Boolean = false): Set[Int]
= {
Review comment:
I think this sounds good, explict over implicit and all that. If we
create two methods should we then make `inSyncReplicaIds` a private member?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
