ableegoldman commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r486753195
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SuppressScenarioTest.java
##########
@@ -493,52 +494,59 @@ public void shouldSupportFinalResultsForSlidingWindows() {
inputTopic.pipeInput("k1", "v1", 7L);
// final record to advance stream time and flush windows
inputTopic.pipeInput("k1", "v1", 90L);
+ final Comparator<TestRecord<String, Long>> comparator =
Review comment:
Actually, I think the timestamp of the forwarded results is now the
window's "event time", ie the maximum timestamp of a record in the window. But
in retrospect I don't see any correctness issues here: for one thing, as I
mentioned in the other comment, this only affects the relative ordering of
updates with different windowed keys. And there's no ordering guarantees
between keys. It also shouldn't even have any impact on advancing stream-time
and potentially dropping some windows due to grace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
