[GitHub] [kafka] mjsax commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

[GitBox]

mjsax commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487169320



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableAbstractJoin.java
##########
@@ -39,9 +39,15 @@
     }
 
     @Override
-    public final void enableSendingOldValues() {
-        table1.enableSendingOldValues();
-        table2.enableSendingOldValues();
+    public final boolean enableSendingOldValues(final boolean 
onlyIfMaterialized) {
+        if (!table1.enableSendingOldValues(onlyIfMaterialized)) {

Review comment:
       My comment was about your pattern... (if we flip the logic, we would 
need to pass in `true` to force a materialization). My point is, shouldn't we 
pass in a constant? For KTableKTableAbstractJoin we always want that the 
upstream is sending us old values.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org