xakassi commented on a change in pull request #9211:
URL: https://github.com/apache/kafka/pull/9211#discussion_r478325832
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##########
@@ -733,10 +734,11 @@ public void onCompletion(Throwable error,
ConsumerRecord<String, byte[]> record)
new SecretKeySpec(key, (String) keyAlgorithm),
(long) creationTimestamp
);
-
- if (started)
-
updateListener.onSessionKeyUpdate(KafkaConfigBackingStore.this.sessionKey);
Review comment:
Hi, @kkonstantine !
Yes, indeed, it looks like we can get rid of the synchronized block here at
all. I think it's safe.
I commited this change.
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##########
@@ -733,10 +734,11 @@ public void onCompletion(Throwable error,
ConsumerRecord<String, byte[]> record)
new SecretKeySpec(key, (String) keyAlgorithm),
(long) creationTimestamp
);
-
- if (started)
-
updateListener.onSessionKeyUpdate(KafkaConfigBackingStore.this.sessionKey);
Review comment:
Hi, @kkonstantine !
Yes, indeed, it looks like we can get rid of the synchronized block here at
all. I think it's safe.
I commited this change.
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##########
@@ -733,10 +734,11 @@ public void onCompletion(Throwable error,
ConsumerRecord<String, byte[]> record)
new SecretKeySpec(key, (String) keyAlgorithm),
(long) creationTimestamp
);
-
- if (started)
-
updateListener.onSessionKeyUpdate(KafkaConfigBackingStore.this.sessionKey);
Review comment:
Hi, @kkonstantine !
Yes, indeed, it looks like we can get rid of the synchronized block here at
all. I think it's safe.
I commited this change.
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##########
@@ -733,10 +734,11 @@ public void onCompletion(Throwable error,
ConsumerRecord<String, byte[]> record)
new SecretKeySpec(key, (String) keyAlgorithm),
(long) creationTimestamp
);
-
- if (started)
-
updateListener.onSessionKeyUpdate(KafkaConfigBackingStore.this.sessionKey);
Review comment:
Hi, @kkonstantine !
Yes, indeed, it looks like we can get rid of the synchronized block here at
all. I think it's safe.
I commited this change.
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java
##########
@@ -733,10 +734,11 @@ public void onCompletion(Throwable error,
ConsumerRecord<String, byte[]> record)
new SecretKeySpec(key, (String) keyAlgorithm),
(long) creationTimestamp
);
-
- if (started)
-
updateListener.onSessionKeyUpdate(KafkaConfigBackingStore.this.sessionKey);
Review comment:
Hi, @kkonstantine !
Yes, indeed, it looks like we can get rid of the synchronized block here at
all. I think it's safe.
I commited this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
