lct45 commented on a change in pull request #9239:
URL: https://github.com/apache/kafka/pull/9239#discussion_r487110043
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -131,14 +157,15 @@ public void testAggregateSmallInput() {
public void testReduceSmallInput() {
final StreamsBuilder builder = new StreamsBuilder();
final String topic = "topic";
+ final WindowBytesStoreSupplier storeSupplier = inOrderIterator ? new
InOrderMemoryWindowStoreSupplier("InOrder", 50000L, 10L, false) :
Stores.inMemoryWindowStore("Reverse", Duration.ofMillis(50000),
Duration.ofMillis(10), false);
Review comment:
These lines ended up being pretty long but I wasn't sure how to best
split them up. WDYT @ableegoldman ?
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -131,14 +157,15 @@ public void testAggregateSmallInput() {
public void testReduceSmallInput() {
final StreamsBuilder builder = new StreamsBuilder();
final String topic = "topic";
+ final WindowBytesStoreSupplier storeSupplier = inOrderIterator ? new
InOrderMemoryWindowStoreSupplier("InOrder", 50000L, 10L, false) :
Stores.inMemoryWindowStore("Reverse", Duration.ofMillis(50000),
Duration.ofMillis(10), false);
Review comment:
These lines ended up being pretty long but I wasn't sure how to best
split them up. WDYT @ableegoldman ?
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -131,14 +157,15 @@ public void testAggregateSmallInput() {
public void testReduceSmallInput() {
final StreamsBuilder builder = new StreamsBuilder();
final String topic = "topic";
+ final WindowBytesStoreSupplier storeSupplier = inOrderIterator ? new
InOrderMemoryWindowStoreSupplier("InOrder", 50000L, 10L, false) :
Stores.inMemoryWindowStore("Reverse", Duration.ofMillis(50000),
Duration.ofMillis(10), false);
Review comment:
These lines ended up being pretty long but I wasn't sure how to best
split them up. WDYT @ableegoldman ?
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -131,14 +157,15 @@ public void testAggregateSmallInput() {
public void testReduceSmallInput() {
final StreamsBuilder builder = new StreamsBuilder();
final String topic = "topic";
+ final WindowBytesStoreSupplier storeSupplier = inOrderIterator ? new
InOrderMemoryWindowStoreSupplier("InOrder", 50000L, 10L, false) :
Stores.inMemoryWindowStore("Reverse", Duration.ofMillis(50000),
Duration.ofMillis(10), false);
Review comment:
These lines ended up being pretty long but I wasn't sure how to best
split them up. WDYT @ableegoldman ?
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -131,14 +157,15 @@ public void testAggregateSmallInput() {
public void testReduceSmallInput() {
final StreamsBuilder builder = new StreamsBuilder();
final String topic = "topic";
+ final WindowBytesStoreSupplier storeSupplier = inOrderIterator ? new
InOrderMemoryWindowStoreSupplier("InOrder", 50000L, 10L, false) :
Stores.inMemoryWindowStore("Reverse", Duration.ofMillis(50000),
Duration.ofMillis(10), false);
Review comment:
These lines ended up being pretty long but I wasn't sure how to best
split them up. WDYT @ableegoldman ?
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -131,14 +157,15 @@ public void testAggregateSmallInput() {
public void testReduceSmallInput() {
final StreamsBuilder builder = new StreamsBuilder();
final String topic = "topic";
+ final WindowBytesStoreSupplier storeSupplier = inOrderIterator ? new
InOrderMemoryWindowStoreSupplier("InOrder", 50000L, 10L, false) :
Stores.inMemoryWindowStore("Reverse", Duration.ofMillis(50000),
Duration.ofMillis(10), false);
Review comment:
These lines ended up being pretty long but I wasn't sure how to best
split them up. WDYT @ableegoldman ?
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -131,14 +157,15 @@ public void testAggregateSmallInput() {
public void testReduceSmallInput() {
final StreamsBuilder builder = new StreamsBuilder();
final String topic = "topic";
+ final WindowBytesStoreSupplier storeSupplier = inOrderIterator ? new
InOrderMemoryWindowStoreSupplier("InOrder", 50000L, 10L, false) :
Stores.inMemoryWindowStore("Reverse", Duration.ofMillis(50000),
Duration.ofMillis(10), false);
Review comment:
These lines ended up being pretty long but I wasn't sure how to best
split them up. WDYT @ableegoldman ?
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
##########
@@ -131,14 +157,15 @@ public void testAggregateSmallInput() {
public void testReduceSmallInput() {
final StreamsBuilder builder = new StreamsBuilder();
final String topic = "topic";
+ final WindowBytesStoreSupplier storeSupplier = inOrderIterator ? new
InOrderMemoryWindowStoreSupplier("InOrder", 50000L, 10L, false) :
Stores.inMemoryWindowStore("Reverse", Duration.ofMillis(50000),
Duration.ofMillis(10), false);
Review comment:
These lines ended up being pretty long but I wasn't sure how to best
split them up. WDYT @ableegoldman ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
