mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r489753946



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -3045,6 +3045,24 @@ class KafkaApis(val requestChannel: RequestChannel,
     }
   }
 
+  def handleAlterIsrRequest(request: RequestChannel.Request): Unit = {
+    val alterIsrRequest = request.body[AlterIsrRequest]
+
+    if (!controller.isActive) {

Review comment:
       This is actually a really good point. I filed a JIRA to fix this in 
other places in KafkaApis https://issues.apache.org/jira/browse/KAFKA-10491




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to