cmccabe commented on pull request #9103: URL: https://github.com/apache/kafka/pull/9103#issuecomment-696225206
Hi @abbccdda , Thanks for the PR! It looks good. I like the idea behind `ForwardRequestHandler`. Since this class doesn't have any internal state, I wonder if it would be more Scala-like to just have a function which just takes some callbacks as arguments. Can we get rid of the need for the `customizedAuthorizationError` callback by having `resourceSplitByAuthorization` return a `Map[RK, ApiError]` instead of `Map[RK, RV]`? When would RV be needed for keys where authorization failed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
