dajac commented on a change in pull request #9301:
URL: https://github.com/apache/kafka/pull/9301#discussion_r492540150
##########
File path:
core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala
##########
@@ -179,17 +179,23 @@ class DynamicConnectionQuotaTest extends BaseRequestTest {
reconfigureServers(props, perBrokerConfig = true,
(KafkaConfig.ListenersProp, newListeners))
waitForListener("EXTERNAL")
+ // we need to set the initialConnectionCount earlier and pass to
verifyConnectionRate method
+ // so that the race condition won't occur for the following multi-thread
test cases
Review comment:
This comment is irrelevant now. I would just say that this is the
expected connection count after each run.
##########
File path:
core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala
##########
@@ -317,6 +325,12 @@ class DynamicConnectionQuotaTest extends BaseRequestTest {
}
}
+ // make sure the connection count state is the same as the
expectedConnectionCount
Review comment:
nit: I would remove this comment. I think that the method is
self-explanatory now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
