abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r493752855
##########
File path: core/src/main/scala/kafka/server/AdminManager.scala
##########
@@ -547,7 +553,8 @@ class AdminManager(val config: KafkaConfig,
None
else {
val id = resourceNameToBrokerId(resource.name)
- if (id != this.config.brokerId)
+ // Under redirection, it is possible to handle config changes targeting
at brokers other than the controller.
Review comment:
The logic is needed when there is an AlterConfigRequest targeting at a
specific broker. Since the non-controller node will no longer handle
AlterConfigs, it is possible to see a redirected changing request with a
broker.id different than the controller broker.id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
