apovzner commented on a change in pull request #9317:
URL: https://github.com/apache/kafka/pull/9317#discussion_r493869256
##########
File path: core/src/main/scala/kafka/network/SocketServer.scala
##########
@@ -1414,7 +1420,8 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,
metrics: Metrics) extend
class ListenerConnectionQuota(lock: Object, listener: ListenerName) extends
ListenerReconfigurable {
@volatile private var _maxConnections = Int.MaxValue
- val connectionRateSensor = createConnectionRateQuotaSensor(Int.MaxValue,
Some(listener.value))
+ val connectionRateSensor: Sensor =
createConnectionRateQuotaSensor(Int.MaxValue, Some(listener.value))
+ val connectionRateThrottleSensor: Sensor =
createConnectionRateThrottleSensor()
Review comment:
I added type because style check suggested (and also checked style
guide) to annotate public members. However, I will change this to package
scope, since we only need an outer class to access them. So, it was useful that
you asked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
