dajac commented on a change in pull request #9334:
URL: https://github.com/apache/kafka/pull/9334#discussion_r494810769
##########
File path:
core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -844,4 +851,72 @@ class TopicCommandWithAdminClientTest extends
KafkaServerTestHarness with Loggin
assertEquals(2, rows.size)
rows(0).startsWith(s"Topic:$testTopicName\tPartitionCount:1")
}
+
+ @Test
+ def testCreateTopicDoesNotRetryThrottlingQuotaExceededException(): Unit = {
+ val adminClient = Mockito.mock(classOf[Admin])
+ val topicService = AdminClientTopicService(adminClient)
+
+ val result = AdminClientTestUtils.createTopicsResult(testTopicName,
Errors.THROTTLING_QUOTA_EXCEEDED.exception())
+ Mockito.when(adminClient.createTopics(ArgumentMatchers.any(),
ArgumentMatchers.any())).thenReturn(result)
Review comment:
That makes sense. I had to introduce an alias for `ArgumentMatchers.eq`
to not conflict with `eq`. I went with `eqThat` to remain inline with `argThat`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
