dajac opened a new pull request #9344:
URL: https://github.com/apache/kafka/pull/9344


   KIP-599 had proposed to keep returning the 
`ThrottlingQuotaExceededException` to the called even when the request times 
out due to reaching `default.api.timeout.ms`. The current implementation does 
not cover this yet.
   
   From KIP-599:
   > Once `default.api.timeout.ms` has been reached, the topics which were 
throttled will return the `ThrottlingQuotaExceededException` to the caller.
   
   This PR adds the logic to preserve the `ThrottlingQuotaExceededException` 
when topics are retried. The `throttleTimeMs` is also adjusted accordingly as 
the request could remain pending or in-flight for quite a long time.
   
   I have run various tests on clusters with enabled quotas and I, indeed, find 
it better to preserve the exception. Otherwise, the caller does not really 
understand what is going on. This allows the caller to take the appropriate 
measure and also to take the `throttleTimeMs` into consideration.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to