chia7712 commented on a change in pull request #9284: URL: https://github.com/apache/kafka/pull/9284#discussion_r495983768
########## File path: core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala ########## @@ -327,10 +327,12 @@ class DynamicBrokerConfigTest { EasyMock.replay(kafkaServer) props.put(KafkaConfig.ListenersProp, "PLAINTEXT://hostname:9092,SASL_PLAINTEXT://hostname:9093") - val newConfig = KafkaConfig(props) + new DynamicListenerConfig(kafkaServer).validateReconfiguration(KafkaConfig(props)) + // it is illegal to update configs of existent listeners + props.put("listener.name.plaintext.you.should.not.pass", "failure") Review comment: you are right. I will revise the comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org