soondenana commented on a change in pull request #9347:
URL: https://github.com/apache/kafka/pull/9347#discussion_r496272243
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java
##########
@@ -163,6 +163,18 @@ public void start() {
log.info("Started KafkaBasedLog for topic " + topic);
}
+ /**
+ * Sleep for some time so that topic used for this KafkaBasedLog gets
created. Note that
+ * {@code System.currentTimeMillis()} is not monotonic, so check for that
condition.
Review comment:
In fact we don't need value from clock to sleep, only need it to find
elapsed time and timeout. I have decoupled these two, and also fixed a minor
issue where it was sleeping first time even if topic was present.
Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
