kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r496535646
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java
##########
@@ -43,7 +43,7 @@
*/
public class ApiVersionsResponse extends AbstractResponse {
- public static final int UNKNOWN_FINALIZED_FEATURES_EPOCH = -1;
+ public static final long UNKNOWN_FINALIZED_FEATURES_EPOCH = -1;
Review comment:
Done.
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -3109,6 +3110,37 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ def handleUpdateFeatures(request: RequestChannel.Request): Unit = {
+ val updateFeaturesRequest = request.body[UpdateFeaturesRequest]
+
+ def sendResponseCallback(errors: Either[ApiError, Map[String, ApiError]]):
Unit = {
+ def createResponse(throttleTimeMs: Int): UpdateFeaturesResponse = {
+ errors match {
+ case Left(topLevelError) => {
+ val featureUpdateNoErrors = updateFeaturesRequest
+ .data().featureUpdates().asScala
Review comment:
Done. Great point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
